Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getContracts(): Support more than 100 instances per code ID #1077

Closed
webmaster128 opened this issue Mar 8, 2022 · 1 comment · Fixed by #1086
Closed

getContracts(): Support more than 100 instances per code ID #1077

webmaster128 opened this issue Mar 8, 2022 · 1 comment · Fixed by #1086
Milestone
0.28.0

Comments

@webmaster128
Copy link
Member

See https://github.com/cosmos/cosmjs/blob/v0.28.0-rc1/packages/cosmwasm-stargate/src/cosmwasmclient.ts#L337-L341
@webmaster128 webmaster128 changed the title Support more than 100 instances per code ID getContracts(): Support more than 100 instances per code ID Mar 10, 2022
@webmaster128
Copy link
Member Author

Let's loop over all pages for now and add a note in the method docs that this is potentially inefficient and advanced apps should consider creating their own query client to handle pagination together with the app's screens.

@msteiner96 msteiner96 mentioned this issue Mar 11, 2022
Merged
@webmaster128 webmaster128 added this to the 0.28.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

getContracts(): Support more than 100 per code ID cosmos/cosmjs
1 participant
@webmaster128