Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ''(empty string) type to BondStatusString to support query all validators #1170

Closed
fantasist-crypto opened this issue Jun 13, 2022 · 8 comments · Fixed by #1171
Closed

add ''(empty string) type to BondStatusString to support query all validators #1170

fantasist-crypto opened this issue Jun 13, 2022 · 8 comments · Fixed by #1171

Comments

@fantasist-crypto
Copy link
Contributor

No description provided.

@webmaster128
Copy link
Member

Isn't that the same as "UNRECOGNIZED"? I.e. the default value of the enum.

@fantasist-crypto
Copy link
Contributor Author

It will throw an error, when I use 'UNRECOGNIZED'.

@webmaster128
Copy link
Member

How does your code look like? What error do you get?

@fantasist-crypto
Copy link
Contributor Author 

queryClient.staking.validators('UNRECOGNIZED')

Screen Shot 2022-06-13 at 17 19 55

@fantasist-crypto
Copy link
Contributor Author

I mean I want get all validators, and it works when I use empty string, but BondStatusString not include empty string.

@webmaster128 webmaster128 mentioned this issue Jun 13, 2022
Merged
@webmaster128
Copy link
Member

Okay, not it makes sense. The comment in #1171 explains the strangeness.

@fantasist-crypto
Copy link
Contributor Author

Nice

@webmaster128 webmaster128 mentioned this issue Jun 14, 2022
Merged
@webmaster128
Copy link
Member

Released as part of 0.28.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BondStatusString values cosmos/cosmjs
2 participants
@webmaster128 @fantasist-crypto