Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction result data to IndexedTx #1305

Closed
webmaster128 opened this issue Oct 25, 2022 · 1 comment · Fixed by #1427
Closed

Add transaction result data to IndexedTx #1305

webmaster128 opened this issue Oct 25, 2022 · 1 comment · Fixed by #1427
Labels
cosmos-sdk-0.47-🤟
Milestone
0.31.0

Comments

@webmaster128
Copy link
Member

webmaster128 commented Oct 25, 2022 •
edited
Loading

@webmaster128 webmaster128 added this to the 0.29.x milestone Oct 25, 2022
@webmaster128
Copy link
Member Author

webmaster128 commented Oct 25, 2022 •
edited
Loading

I'm unsure how to expose this value at higher level APIs (IndexedTx/DeliverTxResponse as well as InstantiateResult and friends) because it changes starting with Cosmos SDK 0.46:

https://github.com/cosmos/cosmos-sdk/blob/v0.46.3/proto/cosmos/base/abci/v1beta1/abci.proto#L128-L140

Adding new MsgData fields does not make much sense anymore. We probably need the Cosmos SDK 0.46 types in cosmjs-types first.

@webmaster128 webmaster128 mentioned this issue Oct 25, 2022
Closed
@webmaster128 webmaster128 modified the milestones: 0.29.x, 0.30.0 Nov 24, 2022
@webmaster128 webmaster128 modified the milestones: 0.30.0, 0.31.0 Dec 8, 2022
@webmaster128 webmaster128 mentioned this issue May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cosmos-sdk-0.47-🤟
Projects
None yet
Milestone
0.31.0
Development

Successfully merging a pull request may close this issue.

Add msgResponses field to IndexedTx and DeliverTxResponse cosmos/cosmjs
1 participant
@webmaster128