Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amino encode not support some special char(<, >, $). #1367

Closed
loin3 opened this issue Feb 7, 2023 · 2 comments · Fixed by #1388
Closed

Amino encode not support some special char(<, >, $). #1367

loin3 opened this issue Feb 7, 2023 · 2 comments · Fixed by #1388
Milestone

Comments

@loin3
Copy link
Contributor

loin3 commented Feb 7, 2023

When Tx memo contain special characters (<, >, $), Amino sign does not working

Step1. Write Tx with memo within special char. ex) "Tx & Send"
Step2. Sign with Secp256k1HdWallet

signature verification failed; please verify account number (1), sequence (7) and chain-id (simd-testing): unauthorized

@loin3
Copy link
Contributor Author

loin3 commented Feb 16, 2023

keplr-wallet already dealt with this problem, but did not contributed to cosmjs.
https://github.com/chainapsis/keplr-wallet/blob/master/packages/common/src/escape/index.ts#L8

@webmaster128
Copy link
Member

Very interesting, thank you for bringing this up. This is indeed not yet implemented.

The Keplr reference is great and helpful.

https://go.dev/play/p/p3RNTpm2LED shows the escaping bahaviour in Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants