Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cosmos-sdk v0.50, TM 0.38 #1464

Closed
Anmol1696 opened this issue Aug 15, 2023 · 4 comments · Fixed by #1466
Closed

Support for cosmos-sdk v0.50, TM 0.38 #1464

Anmol1696 opened this issue Aug 15, 2023 · 4 comments · Fixed by #1466

Comments

@Anmol1696
Copy link

Overview

Pre-release out for cosmos-sdk version v0.50, it would be really helpful if we can start adding support for TM 0.38 which will be used.

@webmaster128
Copy link
Member

In #1466 I tried using the Tendermint 0.37 client for Comet BFT 0.38. But this does not seem to work. We need a separate 0.38 client. Once we have that, we can easily adapt the auto-detection.

@Anmol1696
Copy link
Author

Would it be similar to #1376?

@webmaster128
Copy link
Member

What needs to be done is this:

  1. Copy and commit the tendermint37 folder and Tendermint37Client into tendermint38 and Tendermint38Client. The diff should only be renamings here.
  2. Test the new client against the 0.38 backend (set up in Create CometBFT 0.38 client and auto-detection #1466)
  3. Make all changes required to make tests pass
  4. Adapt the auto-selection in the higher level clients

@webmaster128
Copy link
Member

In #1466 we have Comet 0.38 support done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants