Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package cosmwasm-launchpad #786

Closed
4 tasks done
webmaster128 opened this issue May 4, 2021 · 10 comments
Closed
4 tasks done

Remove package cosmwasm-launchpad #786

webmaster128 opened this issue May 4, 2021 · 10 comments
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented May 4, 2021

Nobody seems to be using this.

@webmaster128 webmaster128 added this to the 0.26.0 milestone May 4, 2021
@ethanfrey
Copy link
Contributor

I don't know if Terra or Secret are using this. Or they are maintaining their own forks?

@YunSuk-Yeo could you comment for Terra?
@reuvenpo could you comment for Secret?

We can also discuss this on Discord if you are using CosmJS and need this support still.
Everyone else should be on stargate already.

@reuvenpo
Copy link

reuvenpo commented May 4, 2021

We use a forked version of CosmJS so I don't think any changes to CosmJS will directly affect us, but I'll let @assafmo comment on this

@assafmo
Copy link
Contributor

assafmo commented May 4, 2021

Yeah, we unfortunately have our own fork. A few months ago I suggested extending CosmJS' API a bit so that Secret Network would be able to use it directly and benefit from the progress you guys are making. Let me know what I can do to make this happen. ☺️

@ethanfrey
Copy link
Contributor

@assafmo thanks for the answer. My memory was you were going to try to wrap CosmWasmSigner rather than the message transformed idea.

Did you try that? Did it hit issues?

Also, are you planning to upgrade to stargate soon? In which case we can just close this and ensure there is a nice path for core reuse with cosmwasm-stargate

@assafmo
Copy link
Contributor

assafmo commented May 4, 2021

No, I didn't try yet to wrap CosmWasmSigner. I should though...

Yes, we will upgrade to Stargate somewhere this year, but I'm not sure if we'll upgrade our CosmWasm version as well, to not break existing contacts. We'll probably just backport bug fixes you guys made in the past 9 months. Is this a problem with CosmJS?

@ethanfrey
Copy link
Contributor

You will need to fork. Support is mainly with wasmd version.

If you will not be running exactly one of our wasmd versions, we will not guarantee support.

@assafmo
Copy link
Contributor

assafmo commented May 4, 2021

Okay, thanks for the info. We'll try to figure out what's the best approach for us.

@ethanfrey
Copy link
Contributor

Correction: x/wasm versions. Of course we expect you to embed it in your app (and I think you swap out with a custom wasmvm which is great for your use case). The main point is it is tested with a certain set of messages and queries and handlers and if those differ, the CosmJS code may not match.

With stargate we put more effort into making it generic. Thus, you could import all the standard components and build SigningSecretClient on those same basic points, not wrapping SigningCosmWasmClient but at the same level as it. That means, just one package for you to maintain and the rest is upstream.

@webmaster128
Copy link
Member Author

Given that Secret uses a fork of CosmJS anyways and there is great potential to reuse latest upstream dependencies, we'll remove the package now. I think replacing some of the higher level functionality with a fork while building on top of lower level CosmJS packages is a solid long term solution.

@webmaster128
Copy link
Member Author

Done 🐎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants