-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove package cosmwasm-launchpad #786
Comments
I don't know if Terra or Secret are using this. Or they are maintaining their own forks? @YunSuk-Yeo could you comment for Terra? We can also discuss this on Discord if you are using CosmJS and need this support still. |
We use a forked version of CosmJS so I don't think any changes to CosmJS will directly affect us, but I'll let @assafmo comment on this |
Yeah, we unfortunately have our own fork. A few months ago I suggested extending CosmJS' API a bit so that Secret Network would be able to use it directly and benefit from the progress you guys are making. Let me know what I can do to make this happen. |
@assafmo thanks for the answer. My memory was you were going to try to wrap CosmWasmSigner rather than the message transformed idea. Did you try that? Did it hit issues? Also, are you planning to upgrade to stargate soon? In which case we can just close this and ensure there is a nice path for core reuse with |
No, I didn't try yet to wrap CosmWasmSigner. I should though... Yes, we will upgrade to Stargate somewhere this year, but I'm not sure if we'll upgrade our CosmWasm version as well, to not break existing contacts. We'll probably just backport bug fixes you guys made in the past 9 months. Is this a problem with CosmJS? |
You will need to fork. Support is mainly with wasmd version. If you will not be running exactly one of our wasmd versions, we will not guarantee support. |
Okay, thanks for the info. We'll try to figure out what's the best approach for us. |
Correction: With stargate we put more effort into making it generic. Thus, you could import all the standard components and build |
Given that Secret uses a fork of CosmJS anyways and there is great potential to reuse latest upstream dependencies, we'll remove the package now. I think replacing some of the higher level functionality with a fork while building on top of lower level CosmJS packages is a solid long term solution. |
Done 🐎 |
Nobody seems to be using this.
packages/cli/examples/coralnet.ts
andpackages/cli/examples/helpers.ts
into a new CosmWasm+Stargatre example (Add new CosmWasm/Stargate example for CLI #849)The text was updated successfully, but these errors were encountered: