Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add HD configurable path support for Faucet. #832

Closed
puneet2019 opened this issue Jun 11, 2021 · 3 comments · Fixed by #852
Closed

Feature Request: Add HD configurable path support for Faucet. #832

puneet2019 opened this issue Jun 11, 2021 · 3 comments · Fixed by #852
Assignees
@webmaster128
Milestone
0.26.0

Comments

@puneet2019
Copy link

Currently In package faucet the HD path Is hardcoded as makeCosmoshubPath. We can make it configurable.
@webmaster128
Copy link
Member

We can make this configurable with an environment variable like FAUCET_PATH_PATTERN="m/44'/118'/0'/0/a" where a is then replaced with the account index.

@webmaster128 webmaster128 added this to the 0.26.0 milestone Jun 11, 2021
@webmaster128 webmaster128 mentioned this issue Jul 22, 2021
Merged
@webmaster128
Copy link
Member

Could you have a look at #852 to check if that fits your needs?

@webmaster128 webmaster128 self-assigned this Jul 22, 2021
@puneet2019
Copy link
Author

yes! that would work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webmaster128 webmaster128

Labels
None yet
Projects
None yet
Milestone
0.26.0
Development

Successfully merging a pull request may close this issue.

Make faucet path configurable cosmos/cosmjs
2 participants
@webmaster128 @puneet2019