Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default address prefix value of AminoTypes #989

Closed
webmaster128 opened this issue Jan 17, 2022 · 0 comments · Fixed by #1014
Closed

Remove default address prefix value of AminoTypes #989

webmaster128 opened this issue Jan 17, 2022 · 0 comments · Fixed by #1014
Milestone

Comments

@webmaster128
Copy link
Member

In

/**
 * A map from Stargate message types as used in the messages's `Any` type
 * to Amino types.
 */
export class AminoTypes {
  private readonly register: Record<string, AminoConverter>;

  public constructor({ additions = {}, prefix = "cosmos" }: AminoTypesOptions = {}) {

there is a default prefix set. But whenever you need to construct this explicitly, you are most likely not the Cosmos Hub. Using "cosmos" as a default makes it easy to forget setting the field correctly.

@webmaster128 webmaster128 added this to the 0.28.0 milestone Jan 17, 2022
@webmaster128 webmaster128 changed the title Remove default prefix value of AminoTypes Remove default address prefix value of AminoTypes Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant