Let Registry constructor argument override default types

[webmaster128]

With the addition systen, the constructor argument and the register method do the same and there is no way to get rid of Coin and MsgSend.

[webmaster128]

This requires adding Coin to defaultRegistryTypes.

[msteiner96]

Just to be sure: You mean these two methods here?

  public constructor(customTypes: Iterable<[string, GeneratedType]> = []) {
    const { cosmosCoin, cosmosMsgSend } = defaultTypeUrls;
    this.types = new Map<string, GeneratedType>([
      [cosmosCoin, Coin],
      [cosmosMsgSend, MsgSend],
      ...customTypes,
    ]);
  }


  public register(typeUrl: string, type: GeneratedType): void {
    this.types.set(typeUrl, type);
  }

So the result should look like that?

public constructor(customTypes: Iterable<[string, GeneratedType]> = []) {
    this.types = new Map<string, GeneratedType>([
      ...customTypes,
    ]);
  }


  public register(typeUrl: string, type: GeneratedType): void {
    this.types.set(typeUrl, type);
  }

[webmaster128]

The old types

      [cosmosCoin, Coin],
      [cosmosMsgSend, MsgSend],

could remain in the registry when no constructor argument is set. Then calling new Registry() is non-breaking and has Con and MsgSend as before. For this to happen we need to turn the default = [] to an optional. Once the constructor argument is set, it overrides the defaults instead of appending.