-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable no-std
and replate cosmos-sdk-proto
to ibc-proto
#404
Conversation
…ependency version
…splaydoc` in cosmrs crate. Also, minor updates error messages in `AccountId`, `public_key`, and `error` modules.
no-std
and replate cosmos-sdk-proto
to ibc-proto
This PR seems to be combining a number of different changes, including rather huge, sweeping, and controversial ones like completely deleting I think something like retiring |
i can spilt. Completely delete cosmos sdk proto because it does not support no std. I want to use ibc proto directly instead. I think it can also merge the proto that two different projects depend on to minimize multiple repositories. |
That's a political decision as much as it is a technical one. You need to get buy in from both maintainers to merge the two projects, and then there's a question of where the resulting code lives. Also, right now this project benefits from having a "monorepo" where we can make cross-cutting changes between Retiring |
I'm currently implementing ics06 solomachine. I want to use the pullickey type in cosmrs directly. I don't want to reimplement it in ibc-rs. I think there will be more problems with ibc-rs and cosmrs intersecting in the future |
close: #397 #398
At present, one of the issues that needs to be addressed is to ensure that the versions of the proto files generated for
cosmos sdk
,ibc
, andwasmd
inibc-proto
correspond to the current library.The overall changes have been made to support
no-std
in cosmrs, replacedcosmos-sdk-proto
withibc-proto
. As for the error handling, I'm not sure if it meets your requirements or if you have any suggestions.