You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working with Cosmos SDK v0.50, I encountered an issue where a governance proposal that omitted a critical parameter (MinDepositRatio in the gov module params) was submitted and accepted. This omission led to the inability to submit further governance proposals, as the code failed when attempting to parse an empty string ("") value..
To address this issue, the gov params module could be adjusted to either use the default value or set the value to 0.00 instead of an empty string.
However, a more comprehensive solution would be to reintroduce the practice of running simulations before proposals are submitted(I did not get why it was removed, tried asking on multiple places and saw somewhere that its for the x/gov+x/group alignment but I don't see why x/gov has to lose this functionality). Every proposal would benefit from having a simulation ran before submission, rather to waiting 3 days to realize your proposal was mispelled, invalid or anything missed.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
While working with Cosmos SDK v0.50, I encountered an issue where a governance proposal that omitted a critical parameter (MinDepositRatio in the gov module params) was submitted and accepted. This omission led to the inability to submit further governance proposals, as the code failed when attempting to parse an empty string ("") value..
To address this issue, the gov params module could be adjusted to either use the default value or set the value to 0.00 instead of an empty string.
However, a more comprehensive solution would be to reintroduce the practice of running simulations before proposals are submitted(I did not get why it was removed, tried asking on multiple places and saw somewhere that its for the x/gov+x/group alignment but I don't see why x/gov has to lose this functionality). Every proposal would benefit from having a simulation ran before submission, rather to waiting 3 days to realize your proposal was mispelled, invalid or anything missed.
Beta Was this translation helpful? Give feedback.
All reactions