Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better logging management in Cosmovisor. #10058

Closed
4 tasks
jgimeno opened this issue Sep 2, 2021 · 1 comment · Fixed by #10217
Closed
4 tasks

Add better logging management in Cosmovisor. #10058

jgimeno opened this issue Sep 2, 2021 · 1 comment · Fixed by #10217
Assignees
@spoo-bar
Labels
C:Cosmovisor Issues and PR related to Cosmovisor

Comments

@jgimeno
Copy link
Contributor

jgimeno commented Sep 2, 2021 •
edited
Loading

Summary

Cosmovisor needs better logging than printing in stdout.

Problem Definition

Right now cosmovisor is doing Println around the code for logging purposes. We need in some moment to use a proper library to log.

Proposal

Use a proper logging library. We can use same as in SDK.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jgimeno jgimeno mentioned this issue Sep 2, 2021
Merged
19 tasks
@clevinson clevinson added the C:Cosmovisor Issues and PR related to Cosmovisor label Sep 3, 2021
@spoo-bar spoo-bar assigned spoo-bar and unassigned spoo-bar Sep 9, 2021
@alexanderbez
Copy link
Contributor

ACK. Just use the zerolog logger from the SDK 👍

@spoo-bar spoo-bar self-assigned this Sep 22, 2021
@spoo-bar spoo-bar mentioned this issue Sep 23, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spoo-bar spoo-bar

Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adding zerolog logging to cosmovisor cosmos/cosmos-sdk
4 participants
@clevinson @jgimeno @alexanderbez @spoo-bar