Refactor middleware tests out of baseapp_test #10282
Labels
C:baseapp
T: Tests
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Part of the tx working group
Summary
Fix technical debt in tests after the baseapp middleware refactor (#9996).
ref: #10028 (comment), #10028 (comment)
Problem Definition
Before #9996, baseapp took care of
runTx/runMsgs
, and some adjacent stuff like branching the stores, panic recovery, indexing events in TM etc.After #9996, all this logic are moved into middlewares (inside
x/auth/middleware
). Howerver, to not overload PRs (#10028), tests that test baseapprunTx/runMsgs
stuff are still kept in thebaseapp_test
package.We should remove all middleware and tx execution tests out from
baseapp_test
intomiddleware_test
.Additionally, in #10028, when moving the tests from the
baseapp
tobaseapp_test
package, we introduced some technical debt (to access private baseapp fields) to solve cycle deps etc (see #10028 (comment)). All this can be removed as part of this refactor.Proposal
baseapp_test
that need middleware should be moved intomiddleware_test
For Admin Use
The text was updated successfully, but these errors were encountered: