Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor middleware tests out of baseapp_test #10282

Closed
4 tasks
amaury1093 opened this issue Oct 1, 2021 · 1 comment
Closed
4 tasks

Refactor middleware tests out of baseapp_test #10282

amaury1093 opened this issue Oct 1, 2021 · 1 comment
Labels
C:baseapp T: Tests Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@amaury1093
Copy link
Contributor

Part of the tx working group

Summary

Fix technical debt in tests after the baseapp middleware refactor (#9996).

ref: #10028 (comment), #10028 (comment)

Problem Definition

Before #9996, baseapp took care of runTx/runMsgs, and some adjacent stuff like branching the stores, panic recovery, indexing events in TM etc.

After #9996, all this logic are moved into middlewares (inside x/auth/middleware). Howerver, to not overload PRs (#10028), tests that test baseapp runTx/runMsgs stuff are still kept in the baseapp_test package.

We should remove all middleware and tx execution tests out from baseapp_test into middleware_test.

Additionally, in #10028, when moving the tests from the baseapp to baseapp_test package, we introduced some technical debt (to access private baseapp fields) to solve cycle deps etc (see #10028 (comment)). All this can be removed as part of this refactor.

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 self-assigned this Oct 4, 2021
@amaury1093 amaury1093 removed their assignment Feb 1, 2022
@amaury1093 amaury1093 added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Feb 1, 2022
@amaury1093
Copy link
Contributor Author

We reverted middlewares so we can close this.

Superseded by #12802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:baseapp T: Tests Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant