Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authz sim tests #11050

Closed
7 tasks
robert-zaremba opened this issue Jan 27, 2022 · 0 comments · Fixed by #11129
Closed
7 tasks

Fix authz sim tests #11050

robert-zaremba opened this issue Jan 27, 2022 · 0 comments · Fixed by #11129

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Jan 27, 2022

Summary

We have few hack in x/authz sim test preventing correct checks.

  • In simtypes.NoOpMsg we put module name where the route / msg url type is expected, example
  • We were passing silently the sim results, when backporting the undeterminism bug, it was found that the result of the sim test is not checked at all: https://github.com/cosmos/cosmos-sdk/pull/10447/files#r793944849
  • Fix all sim test operations to make a success path or deterministic success and failing paths. Currently the MsgExec is always failing.

Bottom line:

  • if the authz sim test would check correctly the return params then the non determinism issue would be handled there.
  • most likely we need to update other sim tests as well.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant