Home flag gets ignored when running help

[maiph]

Summary of Bug

Running simd --home /data query -h ignores the --home flag and creates ~/.simapp

Version

At commit v0.44.6

Steps to Reproduce

rm ~/.simapp
simd --home /data query -h
ls ~/.simapp

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[maiph]

I think I remember this working, maybe it was introduced on tendermint v0.35.0 ?

[config] Add --mode flag and config variable. See ADR-52 @dongsam

After writing this I went to check if cosmos-sdk v0.44.6 was at least using tendermint v0.35.0, but it was at v0.34.14 so my guess is not true ...

[maiph]

Commit v0.46.0-beta1 also has the same problem and running tendermint v0.35.2

[anilcse]

I believe queries will be just based on the rpc endpoint. Not sure what query you are testing. It shouldn't consider home flag at all

[maiph]

But printing the help menu should not need to create the home directory, and if it needs it should honor the home flag.

On my use case I don't let the user write on the home directory and attach a volume on /data, this makes it impossible to ever print the help menu because the cli will always try to create that directory on the user home dir

[anilcse]

I think we can remove the home flag for queries. wdyt @AmauryM @robert-zaremba

[alexanderbez]

Yeah, there's no need for it (unless we ready from a client.toml, not sure if we still have that).