Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command tendermint inspect is failing #12100

Closed
4 tasks
JeancarloBarrios opened this issue May 31, 2022 · 7 comments
Closed
4 tasks

command tendermint inspect is failing #12100

JeancarloBarrios opened this issue May 31, 2022 · 7 comments
Assignees

Comments

@JeancarloBarrios
Copy link
Contributor

JeancarloBarrios commented May 31, 2022

Summary of Bug

During the manual testing for version v.0.46, here

When running simd tendermint inspect the command fails with the following output.

Error: couldn't read GenesisDoc file: open config/genesis.json: no such file or directory

However, the config/genesis.json does exist and the home path is correct.

Version

v0.46

PR
#11548

Steps to Reproduce

simd tendermint inspect


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@JeancarloBarrios
Copy link
Contributor Author

@alexanderbez hey I believe you did the relevant PR, it failing for me could help me out here maybe I set something wrong but we check and could not figure out why it was failing.

@alexanderbez
Copy link
Contributor

@JeancarloBarrios did you try to explicitly pass --home? I do know that Tendermint modified many of its commands.

@JeancarloBarrios
Copy link
Contributor Author

@JeancarloBarrios did you try to explicitly pass --home? I do know that Tendermint modified many of its commands.

Yes, I did run the --home flag explicitly.

@alexanderbez
Copy link
Contributor

Ahh yes, that is because tendermint refactored stuff and now depends on a private global (sighhh). See https://github.com/tendermint/tendermint/blob/v0.35.5/cmd/tendermint/commands/inspect.go#L53

This issue needs to be moved to the Tendermint repo -- the fix is to not use a global, but the short term solution is to just have the inspect command handler call config, err = ParseConfig()

@amaury1093 amaury1093 moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jun 3, 2022
@amaury1093 amaury1093 moved this to 📝 Todo in Cosmos-SDK Jun 3, 2022
@amaury1093 amaury1093 moved this from 💪 In Progress to 📝 Todo in Cosmos-SDK Jun 3, 2022
@amaury1093
Copy link
Contributor

but the short term solution is to just have the inspect command handler call config, err = ParseConfig()

I added this to the current sprint. If someone is lookng for a small task to do, this should be an easy one.

@alexanderbez
Copy link
Contributor

PR is open in TM, but we're downgrading back to 0.34 so I'm not sure this matters. We should check if the issue is present in v0.34.x

@tac0turtle
Copy link
Member

closing this as the inspect cmd wont be coming to tendermint for a little while

Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Aug 3, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants