msg.ValidateBasic is not called in ante handler

[yihuang]

Summary of Bug

Is it expected that msg.ValidateBasic is not called in ante handler, it only calls tx.ValidateBasic which don't call msgs's.

I tried this to verify, patch TestMsg as follows:

diff --git a/testutil/testdata/tx.go b/testutil/testdata/tx.go
index f0b470aade..2d0b7c97be 100644
--- a/testutil/testdata/tx.go
+++ b/testutil/testdata/tx.go
@@ -2,6 +2,7 @@ package testdata

 import (
        "encoding/json"
+       "errors"

        "github.com/stretchr/testify/require"

@@ -76,7 +77,7 @@ func (msg *TestMsg) GetSigners() []sdk.AccAddress {

        return addrs
 }
-func (msg *TestMsg) ValidateBasic() error { return nil }
+func (msg *TestMsg) ValidateBasic() error { return errors.New("test") }

 var _ sdk.Msg = &MsgCreateDog{}

And run go test -v ./x/auth/ante/..., all tests still passes.

Version

main/0.46/0.45

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[amaury1093]

I'm pretty sure it's called here:

cosmos-sdk/baseapp/baseapp.go

Line 645 in 2b7aca7

if err := validateBasicTxMsgs(msgs); err != nil {

.

Do you have a branch with a reproducible test that sends a MsgCreateDog?

[yihuang]

I'm pretty sure it's called here:

cosmos-sdk/baseapp/baseapp.go

Line 645 in 2b7aca7

if err := validateBasicTxMsgs(msgs); err != nil {

.
Do you have a branch with a reproducible test that sends a MsgCreateDog?

I see, I was working on some ante handler related unit tests, and surprised to find it's not called there. Is there a particular reason that tx and msg's ValidateBasic are called at different places?

[amaury1093]

No reason, other than confusing code design. One proposal was for baseapp to do almost nothing (other than holding a reference to the antehandler stack), and putting all logic into antehandlers.

It was attempted in the middlewares ADR, but reverted. I propose to close this issue, and follow-up in #11955 ?

[yihuang]

👌