--dry-run flag returns an error

[iTiky]

Summary of Bug

In order to estimate a transaction gas usage, I'm using the --dry-run flag. This flag leads to creating the keyring.BackendMemory Keyring in the clientCtx. In-memory Keyring returns an error in the client.GetFromFields call because it can't get an account info 🤷‍♂️. That being said, I can't simulate a transaction.

May be I'm doing smth wrong and there is an other method of Tx simulation without an actual Keyring (os / file).

Version

v0.45.8

Steps to Reproduce

Input:

gaiad tx --chain-id ${chainID} --node ${nodeURL} bank send ${accountA_addr} ${accountB_addr} 100stake --dry-run

Output:

Error: key with addressB0CE2842C0F7F3BB12CF0E93F2F968DF09868DC0not found: key not found

[alexanderbez]

That error output doesn't seem right...you should be providing a --from flag. Have you tried that?

[iTiky]

The x/bank module sets the --from auto-magically 😁
I guess the problem is here, it creates an in-memory Keyring which (of course) has no idea about keys and address.

[alexanderbez]

Ahh yes, you're right. That makes sense. Now the question is, why is the key not found error happening. Somewhere in the dry run flow, it's trying to get the key.

@facundomedica any chance you have the ability to look into this?

[julienrbrt]

Have it ever worked in prior version? In v0.46 we've updated the flags to explain that dry-run cannot access the keyring: https://github.com/cosmos/cosmos-sdk/blob/main/client/flags/flags.go#L118

[alexanderbez]

Yes, --dry-run doesn't need access to the keyring because it simulates the tx and thus uses a dummy pubkey. It should still work as it doesn't need access to the keyring.

[julienrbrt]

Fixed by #13673