Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosetta empty error responses to not queryable blocks #13830

Closed
Tracked by #14007
JulianToledano opened this issue Nov 10, 2022 · 0 comments · Fixed by #13832
Closed
Tracked by #14007

Rosetta empty error responses to not queryable blocks #13830

JulianToledano opened this issue Nov 10, 2022 · 0 comments · Fixed by #13832
Labels
C:Rosetta Issues and PR related to Rosetta

Comments

@JulianToledano
Copy link
Contributor

Summary of Bug

Currently calling to /block with a height of a block that is not queryable results in an empty error:

{
  "code": 0,
  "message": "unknown",
  "description": "unknown error",
  "retriable": false,
  "details": {
    "info": "rosetta: (0) unknown"
  }
}

This is because right now only cosmos-sdk/tools/rosetta/lib/errors are being parsed to rosetta errors.

Version

61effe8

Steps to Reproduce

Start rosetta server:

simd rosetta --blockchain Cosmos --network cosmoshub-4 --grpc $GRPC:9090 --tendermint $TENDERMINT:26657 --log_level debug

get the current_block_identifier from /network/status

curl  localhost:8080/network/status -d '{"network_identifier":{"blockchain":"Cosmos", "network":"cosmoshub-4"}}' | jq

{
  "current_block_identifier": {
    "index": 13060921,
    "hash": "D9528ED4B886E5677C7BB90E95B04EE355282F4F08F02B4E14143FA38D271B00"
  },
  ...

make a request to /block with a higher current_block_identifier.index

curl  localhost:8080/block -d '{"network_identifier":{"blockchain":"Cosmos", "network":"cosmoshub-4"},"block_identifier":{"index":13060930}}' | jq

Proposal

Wrap also jsonrpc errors from tendermint to rosetta:

// ToRosetta attempts to converting an error into a rosetta
// error, if the error cannot be converted it will be parsed as unknown
func ToRosetta(err error) *types.Error {
	switch err := err.(type) {
	case *Error:
		return err.rosErr
	case *tmtypes.RPCError:
		return fromTendermintToRosettaError(err).rosErr
	default:
		return ToRosetta(WrapError(ErrUnknown, ErrUnknown.Error()))
	}
}

func fromTendermintToRosettaError(err *tmtypes.RPCError) *Error {
	return &Error{rosErr: &types.Error{
		Code:    int32(err.Code),
		Message: err.Message,
		Details: map[string]interface{}{
			"info": err.Data,
		},
	}}
}

will result in:

{
  "code": -32603,
  "message": "Internal error",
  "retriable": false,
  "details": {
    "info": "height 13060930 must be less than or equal to the current blockchain height 13060921"
  }
}
@julienrbrt julienrbrt linked a pull request Nov 11, 2022 that will close this issue
19 tasks
@mergify mergify bot closed this as completed in #13832 Nov 12, 2022
mergify bot pushed a commit that referenced this issue Nov 12, 2022
## Description

Closes:
#13830
#13827

- Rosetta `/network/status` response:
   * populates `oldest_block_identifier` with `EarliestBlockHeight` from rpc syncInfo
   * tries to populate `genesis_block_identifier` with block of height 1 
     * if block is not queryable, sets value of  `InitialHeight` from genesis doc
       * if not queryable sets same value as `oldest_block_identifier`
- Wrap `github.com/tendermint/tendermint/rpc/jsonrpc/types` errors to rosetta errors
- Split services into its own go files (account, block, mempool, network)


---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@ainhoa-a ainhoa-a added the C:Rosetta Issues and PR related to Rosetta label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants