-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosetta empty error responses to not queryable blocks #13830
Labels
C:Rosetta
Issues and PR related to Rosetta
Comments
19 tasks
19 tasks
mergify bot
pushed a commit
that referenced
this issue
Nov 12, 2022
## Description Closes: #13830 #13827 - Rosetta `/network/status` response: * populates `oldest_block_identifier` with `EarliestBlockHeight` from rpc syncInfo * tries to populate `genesis_block_identifier` with block of height 1 * if block is not queryable, sets value of `InitialHeight` from genesis doc * if not queryable sets same value as `oldest_block_identifier` - Wrap `github.com/tendermint/tendermint/rpc/jsonrpc/types` errors to rosetta errors - Split services into its own go files (account, block, mempool, network) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of Bug
Currently calling to
/block
with a height of a block that is not queryable results in an empty error:This is because right now only
cosmos-sdk/tools/rosetta/lib/errors
are being parsed to rosetta errors.Version
61effe8
Steps to Reproduce
Start rosetta server:
simd rosetta --blockchain Cosmos --network cosmoshub-4 --grpc $GRPC:9090 --tendermint $TENDERMINT:26657 --log_level debug
get the
current_block_identifier
from/network/status
make a request to
/block
with a highercurrent_block_identifier.index
Proposal
Wrap also jsonrpc errors from tendermint to rosetta:
will result in:
The text was updated successfully, but these errors were encountered: