Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: x/evidence as a standalone go module #14557

Closed
Tracked by #11899
kocubinski opened this issue Jan 9, 2023 · 0 comments · Fixed by #14724
Closed
Tracked by #11899

refactor: x/evidence as a standalone go module #14557

kocubinski opened this issue Jan 9, 2023 · 0 comments · Fixed by #14724
Assignees

Comments

@kocubinski
Copy link
Member

kocubinski commented Jan 9, 2023

Ref: #11899

The SDK module dependency graph below (generated from main 2023-01-09) shows that x/evidence has no dependents. Given this it should be trivial to create a go.mod for this module and separate it from the SDK monolith.

image

x/evidence has dependencies on the SDK modules shown below. As a part of this issue lets do a cursory review and remove them if trivial, or punt to the dependency's issue if not.

$ goFmtString="{{ \$importPath := .ImportPath }} {{ \$forTest := .ForTest }}                                                               
{{ range .Imports }} {{ if \$forTest }} {{ \$forTest }}.test {{else}} {{ \$importPath }} {{end}}-> {{ . }}
{{ end }}"
$ go list -test -f "$goFmtString" ./... | awk -F'->' '$2 ~ "github.com/cosmos/cosmos-sdk/x/"' | awk -F'->' '$2 !~ "github.com/cosmos/cosmos-sdk/x/evidence"'
  github.com/cosmos/cosmos-sdk/x/evidence/keeper -> github.com/cosmos/cosmos-sdk/x/staking/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/auth
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/auth/tx/config
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/auth/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/bank
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/bank/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/consensus
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/consensus/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/genutil
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/genutil/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/mint/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/params
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/params/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/slashing
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/slashing/types
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/staking
  github.com/cosmos/cosmos-sdk/x/evidence/testutil -> github.com/cosmos/cosmos-sdk/x/staking/types
  github.com/cosmos/cosmos-sdk/x/evidence/types -> github.com/cosmos/cosmos-sdk/x/authz/codec
  github.com/cosmos/cosmos-sdk/x/evidence/types -> github.com/cosmos/cosmos-sdk/x/gov/codec
  github.com/cosmos/cosmos-sdk/x/evidence/types -> github.com/cosmos/cosmos-sdk/x/group/codec
  github.com/cosmos/cosmos-sdk/x/evidence/types -> github.com/cosmos/cosmos-sdk/x/staking/types

List of To-dos when creating a go.mod: https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#gomod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants