Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out right user-facing API for HD keys #1480

Closed
cwgoes opened this issue Jun 29, 2018 · 3 comments
Closed

Figure out right user-facing API for HD keys #1480

cwgoes opened this issue Jun 29, 2018 · 3 comments
Assignees
Labels

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jun 29, 2018

The keybase now uses HD-derived keys by default, so we need to choose a derivation path (which may or may not be the same as the fundraiser derivation path?), support deriving multiple addresses, etc.

gaiacli add --ledger already supports some HD functionality; we can decide if we want to mirror that for normal keys or do something else.

@ValarDragon
Copy link
Contributor

We should have the default HD path be clearly documented. Was the fundraiser using hardened HD derivation? If not, then I think we should use a different HD derivation path as the default.

How's the following for the UI:

$ gaiacli keys add --use-hd-path <hd path>
<if path matches a saved HD-wallet path>
Do you want to use one of the following known hd wallet seeds (enter one of the names, or no):
<Saved hd wallet seeds>
if yes ask password for that seed and complete (involves setting password for new key)
if no, ask for hd wallet seed, and complete (involves setting password for new key)

We should provide a seperate command for going from secret to master seed, and master seed to wallet seed at the given path.

Linking the graphic w/ the terms on it here

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 26, 2018

Do we still want to make changes on this front (cc @ebuchman)?

@ValarDragon ValarDragon removed their assignment Nov 29, 2018
@cwgoes cwgoes assigned alessio and unassigned liamsi and cwgoes Nov 30, 2018
@fedekunze fedekunze added C:Ledger Issues and features related Ledger integration and functionality and removed C:Ledger Issues and features related Ledger integration and functionality labels Apr 7, 2019
@jackzampolin
Copy link
Member

Going to close this issue. Don't think we need to do anymore here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants