-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Keyring refactor #14940
Comments
for this one we can try using cockroachdb/errors instead of our library as it provides some extra functionality |
Have we looked into using the hashicorp plugins here? |
yup yup, zondax is working on a design doc |
I have been working on a Proof of Concept for a keyring that leverages HashiCorp plugins over gRPC. The code for this POC can be found in this repository. In this POC, the keyring fulfills the Cosmos keyring interface, but only the methods for creating keys, retrieving keys, and signing messages have been implemented. There are two plugins available: one written in Go and the other in Python. Both plugins are functional, and I have successfully used them to send some ATOM. I have encountered some issues while working on it, which are explained in the readme. Could you take a look at the code and share your thoughts, as well as any suggestions for next steps. |
closing this in favor of #16637 once the ADR is approved we can create the related tasks |
As we talked in #14473 the main goal will be to have keystone working and integrated in the sdk.
To do so, here is the list of future works:
Phase 1: current keyring small refactors
cockroachdb/errors
instead of the deprecatedgit.luolix.top/cosmos/cosmos-sdk/types/errors
Refactor of erros in keyring #14970unit/integration test
and add them to CI Refactor of keyring tests #14976Phase 2: Maintein keystone
Phase 3: Integrate on the sdk
99desings
The text was updated successfully, but these errors were encountered: