Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Keyring refactor #14940

Closed
4 of 11 tasks
Tracked by #16220
JulianToledano opened this issue Feb 7, 2023 · 5 comments
Closed
4 of 11 tasks
Tracked by #16220

EPIC: Keyring refactor #14940

JulianToledano opened this issue Feb 7, 2023 · 5 comments
Assignees
Labels
C:Keys Keybase, KMS and HSMs S:zondax Squad: Zondax

Comments

@JulianToledano
Copy link
Contributor

JulianToledano commented Feb 7, 2023

As we talked in #14473 the main goal will be to have keystone working and integrated in the sdk.

To do so, here is the list of future works:

Phase 1: current keyring small refactors

Phase 2: Maintein keystone

  • Fix and maintain keystone
    • Have a working release
    • Define an interface that facilitates the development and integration of different backends
    • Implement the same backends already supported in the current keyring
    • Add unit/integration tests

Phase 3: Integrate on the sdk

  • Integrate keystone on the sdk along side with the current keyring
  • Replace the current keyring for keystone to remove the dependency with 99desings
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Feb 7, 2023
@tac0turtle
Copy link
Member

  • Use cosmossdk.io/errors instead of the deprecated github.com/cosmos/cosmos-sdk/types/errors

for this one we can try using cockroachdb/errors instead of our library as it provides some extra functionality

@ainhoa-a ainhoa-a added the C:Keys Keybase, KMS and HSMs label Feb 8, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Feb 8, 2023
@tac0turtle tac0turtle removed the needs-triage Issue that needs to be triaged label Feb 8, 2023
@ainhoa-a ainhoa-a moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Feb 15, 2023
@ainhoa-a ainhoa-a added the S:zondax Squad: Zondax label Feb 15, 2023
@jackzampolin
Copy link
Member

Have we looked into using the hashicorp plugins here?

@tac0turtle
Copy link
Member

yup yup, zondax is working on a design doc

@JulianToledano
Copy link
Contributor Author

JulianToledano commented Jun 8, 2023

Hi @tac0turtle @jackzampolin

I have been working on a Proof of Concept for a keyring that leverages HashiCorp plugins over gRPC. The code for this POC can be found in this repository.

In this POC, the keyring fulfills the Cosmos keyring interface, but only the methods for creating keys, retrieving keys, and signing messages have been implemented.

There are two plugins available: one written in Go and the other in Python. Both plugins are functional, and I have successfully used them to send some ATOM.

I have encountered some issues while working on it, which are explained in the readme. Could you take a look at the code and share your thoughts, as well as any suggestions for next steps.

@JulianToledano
Copy link
Contributor Author

JulianToledano commented Aug 15, 2023

closing this in favor of #16637 once the ADR is approved we can create the related tasks

@github-project-automation github-project-automation bot moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Aug 15, 2023
@tac0turtle tac0turtle moved this to 🥳 Done in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs S:zondax Squad: Zondax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants