Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormatDec test failing on math #15214

Closed
julienrbrt opened this issue Feb 28, 2023 · 0 comments · Fixed by #15215
Closed

FormatDec test failing on math #15214

julienrbrt opened this issue Feb 28, 2023 · 0 comments · Fixed by #15215
Labels
T: Tests

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Feb 28, 2023 •
edited
Loading

Math imports:

cosmos-sdk/math/dec_test.go

Line 674 in 88909d6

raw, err := os.ReadFile("../x/tx/textual/internal/testdata/decimals.json")

but it has changed in https://github.com/cosmos/cosmos-sdk/pull/15129/files.

Making the tests fail: https://github.com/cosmos/cosmos-sdk/actions/runs/4286251512/jobs/7465569471

We possibly should copy that file directly in math before #15129. It was weird anyway to import it from another module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(math): fix FormatDec test cosmos/cosmos-sdk
1 participant
@julienrbrt