Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/staking v0.47...v0.50 #16507

Closed
atheeshp opened this issue Jun 12, 2023 · 2 comments
Closed

Audit x/staking v0.47...v0.50 #16507

atheeshp opened this issue Jun 12, 2023 · 2 comments
Assignees
@atheeshp
Labels
C:x/staking T: Audit

Comments

@atheeshp
Copy link
Contributor

atheeshp commented Jun 12, 2023 •
edited
Loading

no core logic changes, except an index added to iterate over validator delegations.

observed changes:

  • error returns in keeper
  • sdk.Context to context.Context
  • storeService
  • addressCodec changes
  • ValidateBasic changes migrated to msg_server

what to do with

  • code coverage in keeper module is just ~ 50%
  • TODOs without issue references found
@atheeshp atheeshp mentioned this issue Jun 12, 2023
Closed
52 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 12, 2023
@atheeshp atheeshp self-assigned this Jun 12, 2023
@atheeshp atheeshp added C:x/staking T:Sprint T: Audit and removed needs-triage Issue that needs to be triaged labels Jun 12, 2023
@atheeshp atheeshp mentioned this issue Jun 30, 2023
Merged
19 tasks
@cool-develope
Copy link
Contributor

LGTM, @atheeshp can we close it?

@atheeshp
Copy link
Contributor Author

Yes, let's close it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
C:x/staking T: Audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tac0turtle @cool-develope @atheeshp