Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow overriding the client.toml config #17253

Closed
ValarDragon opened this issue Aug 1, 2023 · 2 comments · Fixed by #17513
Closed

[Feature]: Allow overriding the client.toml config #17253

ValarDragon opened this issue Aug 1, 2023 · 2 comments · Fixed by #17513
Assignees

Comments

@ValarDragon
Copy link
Contributor

Summary

Duplicate of #5540 , but for client.toml

Problem Definition

We would like to override some client displays and inputs in Osmosis, based on new config options we'd add to client.toml.

We're currently doing this the "old" way we did app.toml. It would be preferrable to do the more composable solution built for app.toml, if its not too much work to add it for client.toml :)

@julienrbrt
Copy link
Member

Just curious, what is the "old" way? Is it like Juno is doing (https://github.com/CosmosContracts/juno/blob/66c7a1e54c231f408722b43d5e99ea6f42a1e303/cmd/junod/cmd/config.go#L148)?

@ValarDragon
Copy link
Contributor Author

I think it looks fiarly similar: https://github.com/osmosis-labs/osmosis/blob/1735d8b83bd351c26885efb41c1861c99de010fb/cmd/osmosisd/cmd/config.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants