Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support display mnemonic discreetly for keys mnemonic #18685

Closed
Halimao opened this issue Dec 11, 2023 · 1 comment · Fixed by #18688
Closed

[Feature]: Support display mnemonic discreetly for keys mnemonic #18685

Halimao opened this issue Dec 11, 2023 · 1 comment · Fixed by #18688

Comments

@Halimao
Copy link
Contributor

Halimao commented Dec 11, 2023

Summary

Ref #18662 #18668

simd keys mnemonic will also show mnemonic in output, we can show it discreetly on an alternate screen.

Problem Definition

As simd keys mnemonic will show the mnemonic, it would be more safe if we display mnemonic on an alternate screen

Proposed Feature

After we run simd keys mnemonic, the mnemonic will show on an alternate screen, with some prompt msg. With 'Enter' key press, will bring user back to original screen.

if user provide --indiscreet flag, will show on current terminal directly.

@Halimao
Copy link
Contributor Author

Halimao commented Dec 11, 2023

I will draft a pr for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant