[Bug]: NewIntegrationApp does not write default genesis to state

[silasdavis]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

In trying to use the NewIntegrationApp helper to test a module I noticed that the state written by InitChain sourced from DefaultGenesis is not written to state.

Cosmos SDK Version

main

How to reproduce?

To reproduce, run a modified Example_oneModule from https://github.com/cosmos/cosmos-sdk/blob/main/tests/integration/example/example_test.go#L119

See this PR/commit for a minimal repro:

silasdavis#1

In that commit I have removed the part of the test that calls RunMsg to set the the params with MaxMemoCharacters changed to 1000.

I would expect to see the params take their default values.

Instead of observing params that take on the values set by DefaultGenesis you see that the params take on the zero value of the Params struct, indicating that the InitChain is not writing the initial genesis state to the underlying IAVL tree.

[silasdavis]

It would be great to know a if there is an obvious workaround for writing the state written into the keeper during initgenesis down into the IAVL state.

[facundomedica]

Hey @silasdavis, it does look like a bug in the integration app. Seems like the issue here is how we handle contexts, as we pass in one context that doesn't really get used to write the data, and then we use another ctx to read the data. In the full test it works because we use the same context for running the MsgUpdateParams and for getting the params.
I'll need to do some more digging before knowing how to fix it.

[Thomas-Kim]

Any blockers/ETA on fixing this?

For my use case I fixed it by changing SetInitChainer to use sdkCtx in NewIntegrationApp, though I am not sure how it affects any other projects/tests.