-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Bring back block inclusion flag for txs #18927
Comments
Hey, this was removed due to block being made for testing and having bled into production. Unfortunately, we wont be adding it back. We recommend using a js library like cosmjs to make your life easier or using a wallet |
Can you elaborate why it is an issue having this feature? Other teams (Osmosis) also complained. |
Would really appreciate this being added back as well. This automates the most common setup flow, and works great under the happy path |
I believe Crypto.com added a command that would do pretty much the same thing. |
The command/usage is faulty because often times you'd get an RPC error since block inclusion can take much longer than the RPC timeouts. In testing environments, this can be easily controlled to an extent, but in practical environments, it's not really reliable. |
Found the command alternative from cdc: #17274 |
Can't you handle RPC timeout and block inclusion separately? So instead of waiting, keep polling? |
This looks cool. This only got added recently? Can't find the command in latest Osmosis. |
No because broadcasting txs happens via CometBFT's |
Should be available from v0.47.5. Maybe osmosis didn't add it to their app. |
Summary
Before you could
-b block
so the tx send via the CLI would wait for the tx to be included and then return the result. This got removed.Problem Definition
Having shell scripts around the CLI got a lot more complex because of this removal.
Proposed Feature
Bring back the same feature as there was before.
The text was updated successfully, but these errors were encountered: