Weird things happen once #active validators + #revoked validators = max_validators

[gamarin2]

Summary of Bug

After number of active validators+number of revoked validators = max_validators, some weird things start happening.

First problem, number of revoked validators should not count towards max_validators, as per #1888 (comment).

Second, it seems that after the aforementioned condition is met, some unbonded validator can't enter the active validator set anymore.

This is heavily related to #1888 (comment).

Steps to Reproduce

Meet the aforementioned condition. Then try to get an unbonded validator in the val set.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[cwgoes]

I think this is just a symptom of duplicate store keys caused by #1839 not being updated when validators are jailed.

If we want to debug this further, we'll need to look at specific instances and specific transactions.

[rigelrozanski]

I second @cwgoes - it sounds like it was the same root cause - I'd propose this issue get closed unless specific bug cases can be reproduced on the develop branch.

[gamarin2]

Ok, closing for now. Will reopen if issue shows up on upcoming testnets