Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Justify decimal places for core mechanisms #1916

Closed
rigelrozanski opened this issue Aug 3, 2018 · 5 comments
Closed

Justify decimal places for core mechanisms #1916

rigelrozanski opened this issue Aug 3, 2018 · 5 comments
Labels
spec

Comments

@rigelrozanski
Copy link
Contributor

rigelrozanski commented Aug 3, 2018 •
edited
Loading

ref #1819

  • this justification will be "hand" example calculations which go through core calculations as per Jae's insights this is probably the best way to determine the minimum decimal places as opposed to some sort of code example.
  • we should get the piggy bank fees in here before we do these example calculations as that one may be the limiting factor
@rigelrozanski rigelrozanski mentioned this issue Aug 3, 2018
Merged
9 tasks
@alexanderbez
Copy link
Contributor

First point is a bit confusing @rigelrozanski ?

@cwgoes
Copy link
Contributor

cwgoes commented Aug 5, 2018

Ref #1819 (review)

@rigelrozanski
Copy link
Contributor Author

@alexanderbez so weird sorry - editing now.

@ValarDragon
Copy link
Contributor

I think we can close this? Fee distribution should be the limiting factor, and thats tracked in #3039

@rigelrozanski
Copy link
Contributor Author

Agreed - The only other place where decimals is used is in the delegator shares mechanism which is not nearly as constrained as distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexanderbez @ValarDragon @rigelrozanski @cwgoes