Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Transaction Lifecycle section to be updated #20173

Closed
Tracked by #139
samricotta opened this issue Apr 24, 2024 · 0 comments · Fixed by #20284
Closed
Tracked by #139

[Documentation]: Transaction Lifecycle section to be updated #20173

samricotta opened this issue Apr 24, 2024 · 0 comments · Fixed by #20284
Assignees
Labels
T:Docs Changes and features related to documentation.

Comments

@samricotta
Copy link
Contributor

samricotta commented Apr 24, 2024

Summary

The overall feeling of this page is a bit disjointed. The role of FinalizeBlock isnt defined clearly. Additionally we could mention the application mempool is also available. I think the whole section may need a whole rewrite e.g.

In order to verify a Tx, full-nodes call CheckTx, which includes both stateless and stateful checks. 
Further validation happens later in the DeliverTx stage. CheckTx goes through several steps, beginning with decoding Tx

The above is a snippet as an example from outdated documentation and mixing of terminologies

@samricotta samricotta added the T:Docs Changes and features related to documentation. label Apr 24, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Apr 24, 2024
@samricotta samricotta self-assigned this May 14, 2024
@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jun 3, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Jun 18, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant