Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regression, nested multisigs fail marshal/unmarshal in main #20382

Closed
1 task done
facundomedica opened this issue May 14, 2024 · 4 comments
Closed
1 task done
Assignees
Labels

Comments

@facundomedica
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

This works on v0.50 but not on main.

./build/simd keys add alice --keyring-backend test 
./build/simd keys add alicems --multisig alice --multisig-threshold 1
./build/simd keys add alicemstwo --multisig alice,alicems --multisig-threshold 2
./build/simd keys list

Errors:

panic: amino binary marshal marshaling error for {TypeUrl:/cosmos.crypto.secp256k1.PubKey Value:[10 33 3 199 228 92 233 213 255 97 11 242 175 129 193 69 103 73 176 130 222 220 177 157 207 204 60 255 94 220 18 109 241 229 209] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0 cachedValue:0x140016d6048 compat:<nil>}, this is likely because amino is being used directly (instead of codec.LegacyAmino which is preferred) or UnpackInterfacesMessage is not defined for some type which contains a protobuf Any either directly or via one of its members. To see a stacktrace of where the error is coming from, set the var Debug = true in codec/types/compat.go
unable to unmarshal item.Data: "no registered implementations of type multisig.LegacyAminoPubKey"

Cosmos SDK Version

main

How to reproduce?

No response

@julienrbrt
Copy link
Member

Closed by #20438

@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Jun 17, 2024
@facundomedica
Copy link
Member Author

This has not been fixed, the issue has resurfaced :/

@facundomedica facundomedica reopened this Jun 18, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 📋 Backlog in Cosmos-SDK Jun 18, 2024
@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jun 24, 2024
@julienrbrt
Copy link
Member

This has been solved (I tried to reproduce with latest main)

@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Aug 29, 2024
@facundomedica
Copy link
Member Author

Yes, thank you! It was fixed in these 2: #21019 and #21013.

The initial fix PR which was reverted contains a step by step replication: #20438

@tac0turtle tac0turtle removed this from Cosmos-SDK Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants