-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Remove --select in block command #2060
Conversation
e97481d
to
6b8e0ed
Compare
I saw a TODO that said 'actually honor --select' that I removed... I suggest we instead track that in a GitHub issue as opposed to a TODO comment. I'm also happy to implement that if that'll be more valuable than this PR, just let me know. |
Codecov Report
@@ Coverage Diff @@
## develop #2060 +/- ##
========================================
Coverage 63.83% 63.83%
========================================
Files 113 113
Lines 6684 6684
========================================
Hits 4267 4267
Misses 2133 2133
Partials 284 284 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK -- I suggest creating a new issue and reference that here (for honoring --select
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; please rebase against develop and check the CI failures.
LGTM |
Closes #1968.
docs/
)PENDING.md
that include links to the relevant issue or PR that most accurately describes the change.cmd/gaia
andexamples/
For Admin Use: