Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files while using buf #21683

Open
1 task done
julienrbrt opened this issue Sep 12, 2024 · 2 comments
Open
1 task done

Exclude files while using buf #21683

julienrbrt opened this issue Sep 12, 2024 · 2 comments
Labels
C: Proto Proto definition and proto release

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Sep 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

We need to find a way to exclude files when generating protos with buf.
For instance, we want bank protos v1beta1 and v2 to be in the same buf modules.
However, bank v2 will support handlers, and do not require grpc gateway file to be generated (#20798)

We should figure out a way how to exclude files from buf in the buf.yaml (https://github.com/cosmos/cosmos-sdk/pull/21659/files#diff-50e488c6e15cfeba84c617c17b6c9f0e04ea2d65a855c97e0d2fa74f130e15a7R6-R8).

I am not sure if it is supported, but we need it ref: bufbuild/buf#224 and #21659

Cosmos SDK Version

main

@julienrbrt julienrbrt added the C: Proto Proto definition and proto release label Sep 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Sep 12, 2024
@JulianToledano
Copy link
Contributor

I think it may be possible with v2 and the new input lists and exclude_paths.

https://buf.build/docs/configuration/v2/buf-gen-yaml/?query=exclude_paths#include_wkt

@julienrbrt
Copy link
Member Author

Good one! We should probably do that before 0.52 to be aligned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Proto Proto definition and proto release
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants