Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for ConsensusAuthority for comet server in app v2 #21731

Closed
julienrbrt opened this issue Sep 14, 2024 · 0 comments · Fixed by #21734
Closed

Remove need for ConsensusAuthority for comet server in app v2 #21731

julienrbrt opened this issue Sep 14, 2024 · 0 comments · Fixed by #21734
Assignees
@tac0turtle
Labels
C:server/v2 cometbft C:server/v2 Issues related to server/v2

Comments

@julienrbrt
Copy link
Member

We extend AppI with ConsensusAuthority and make the authority of the consensus module itself.

This prohibits governance proposals and is very hacky. We should simplify that.
@julienrbrt julienrbrt self-assigned this Sep 14, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Sep 14, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Sep 14, 2024
@julienrbrt julienrbrt added C:server/v2 Issues related to server/v2 C:server/v2 cometbft and removed needs-triage Issue that needs to be triaged labels Sep 14, 2024
@julienrbrt julienrbrt removed the status in Cosmos-SDK Sep 14, 2024
@julienrbrt julienrbrt moved this to 🤸‍♂️ In Progress in Cosmos-SDK Sep 14, 2024
@tac0turtle tac0turtle mentioned this issue Sep 14, 2024
Merged
12 tasks
@julienrbrt julienrbrt assigned tac0turtle and unassigned julienrbrt Sep 14, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Sep 16, 2024
@mergify mergify bot mentioned this issue Sep 16, 2024
Merged
12 tasks
@tac0turtle tac0turtle removed this from Cosmos-SDK Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
C:server/v2 cometbft C:server/v2 Issues related to server/v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove consensus authority cosmos/cosmos-sdk
2 participants
@tac0turtle @julienrbrt