-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails in Go 1.10.3, 1.10.4 and 1.11 #2253
Comments
It also works with 1.10.3 |
I failed too. go version go1.10.3 linux/amd64 make install github.com/cosmos/cosmos-sdk/storestore/iavlstore.go:43:8: undefined: iavl.VersionedTree go test -v iavlstore_test.go command-line-arguments./iavlstore_test.go:32:41: undefined: iavl.VersionedTree |
@flyq I believe you need to update your vendor dependencies. |
/cc @zmanian |
I think we just need to update our dependency for brejski/hid. |
If you update Are folks only having problems on MacOS or linux/windows as well? Should we pull packages living under |
that's with the latest update to master as suggested by @zmanian. Notice its the same line but different error as Sunny. using: |
passes once upgraded to |
^ ditto. works now for me |
Closing due to fix |
Still running into this issue on
|
latest develop still passes for me (with newest deps), I'm running |
Able to replicate. I had to upgrade to |
ya, i got the exact same error on 1.10.3 and 1.11 did the trick |
fails for me with |
@RomanBrodetski can you update your vendor dependencies? |
After running |
I know go modules aren't supported yet, but thought I'd put this here. Getting similar errors on
|
@shanev you need to update you vendor dependencies: |
@alexanderbez I'm using go modules introduced in go 1.11. It downloads modules to |
I see. I dont know if we have plans on supporting or using modules yet. |
It seems like the migration path to https://github.com/golang/go/wiki/Modules#how-to-define-a-module |
Getting similar errors on go1.11 darwin/amd64 running make get_vendor_deps and them compiling still results in the same error. |
On a brand-new install, after a successful
edit: thanks to @xla I can get it built:
|
I had the same issue. @adrianbrink
|
@mabodx please update the vendor deps. iirc, |
@alexanderbez Right now master is 416181b, which lists github.com/brejski/hid in Gopkg.lock:
It's a transitive dependency of github.com/zondax/ledger-goclient, imported by crypto/ledger.go. |
So if you aren't getting it from |
@zmanian Because cosmos/cosmos-sdk has checked in a Gopkg.lock file, dep won't pick a version of any dependency (direct or transitive) for me, it will use the specific revision that's recorded in that file. "The correct hid version" is the one that's listed there: 06112dc, not 48b08af. To get me to use the latest rev 48b08af, a maintainer needs to re-run dep ensure, maybe via dep ensure -update github.com/brejski/hid, commit the resulting Gopkg.lock to master, and push that change. |
Okay. I am asking for consensus on doing a |
Using a vendored copy of Cosmos SDK. Gopkg.toml:
Dep seems to resolve an older version of tendermint/iavl for some reason.
|
For anyone else having issues with vendored use, try this [[constraint]]
name = "github.com/cosmos/cosmos-sdk"
branch = "develop"
[[override]]
name = "github.com/tendermint/iavl"
version = "=v0.11.0"
[[override]]
name = "github.com/tendermint/tendermint"
version = "=v0.23.1-rc0" Works for 1e26ba2. |
@shanev I've experienced similar issues with using the SDK...as an SDK. Hoping with 0.25 many of these dependency issues will be resolved. Thanks! |
similar issues...
works without package lock |
As a quick fix, try
|
I create a new project using cosmos-sdk-cli
|
You need go1.11 to build the SDK at this point. |
upgrade to 1.11.1 same error
|
This works for me.
|
Did you make the |
yeah |
Here's an update using the latest
[[constraint]]
name = "github.com/cosmos/cosmos-sdk"
branch = "develop"
Fun error:
For some reason, just including Cosmos as a dependency does not pick up the right versions of dependencies. Tendermint is v0.23.1, and IAVL is v0.8.1. |
thank you! this line fixed my install error
go version go1.11.1 darwin/amd64 |
We are now successfully building with Go 1.11.4. Hence closing. |
Summary of Bug
I believe this is from the Ledger dependency:
Steps to Reproduce
Run
make
when using Go 1.10.4 or 1.11. Works with 1.10.1I did not test 1.10.2 and 1.10.3
For Admin Use
The text was updated successfully, but these errors were encountered: