Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseapp: Automatically add action tags to messages #2366

Merged
merged 1 commit into from
Sep 21, 2018
Merged

baseapp: Automatically add action tags to messages #2366

merged 1 commit into from
Sep 21, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Sep 20, 2018 •
edited
Loading

Closes #1406

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests - Is it needed right now?

  • Updated relevant documentation (docs/) - anything I should be updating?

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon ValarDragon removed the request for review from ebuchman September 20, 2018 22:00
@ValarDragon ValarDragon added ready-for-review T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Sep 20, 2018
alexanderbez
alexanderbez approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

cwgoes
cwgoes approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 7823b9b into develop Sep 21, 2018
@cwgoes cwgoes deleted the dev/auto_add_action_tag branch September 21, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @alexanderbez @cwgoes