Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit tests to ensure tags get added #2645

Closed
ValarDragon opened this issue Oct 31, 2018 · 4 comments
Closed

Make unit tests to ensure tags get added #2645

ValarDragon opened this issue Oct 31, 2018 · 4 comments

Comments

@ValarDragon
Copy link
Contributor

ref #2643

We should make sure that tags are actually getting added within unit test cases for each message type.

@jackzampolin
Copy link
Member

This is a great task.

@fedekunze
Copy link
Collaborator

@jackzampolin can we assign someone else plz ? I have a lot on my plate atm and I agree that we should add these test sooner than later

@alexanderbez
Copy link
Contributor

Either way, this should hold off until the new events system is in place.

@fedekunze fedekunze removed their assignment Jun 28, 2019
@jackzampolin
Copy link
Member

Maybe now that the new events system is in place this is a good issue to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants