Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default commit timeout is 5 microseconds because of changes in TM #2742

Closed
4 tasks
hendrikhofstadt opened this issue Nov 9, 2018 · 1 comment
Closed
4 tasks

Default commit timeout is 5 microseconds because of changes in TM #2742

hendrikhofstadt opened this issue Nov 9, 2018 · 1 comment

Comments

@hendrikhofstadt
Copy link
Contributor

The Tendermint config was modified to use the time type instead of millisecond ints.

That means that:

cosmos-sdk/server/util.go

Line 95 in a4af659

conf.Consensus.TimeoutCommit = 5000

Now sets the commit timeout to 5 microseconds instead of 5 seconds.

it should be

conf.Consensus.TimeoutCommit = 5 * time.Second

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hendrikhofstadt hendrikhofstadt mentioned this issue Nov 9, 2018
Merged
5 tasks
@alexanderbez
Copy link
Contributor

So TimeoutCommit was changed to time.Duration (which is based on nanoseconds)? Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hendrikhofstadt @alexanderbez