Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Remove redundant action tag in x/gov #3328

Merged
merged 2 commits into from
Jan 21, 2019
Merged

R4R: Remove redundant action tag in x/gov #3328

merged 2 commits into from
Jan 21, 2019

Conversation

hendrikhofstadt
Copy link
Contributor

@hendrikhofstadt hendrikhofstadt commented Jan 20, 2019

The transaction action tag is already set in runMsgs of baseapp.go. Ref: #2943

tags = append(tags, sdk.MakeTag(sdk.TagAction, []byte(msg.Type())))

Redundant tags make it hard to distinguish between results of multiple messages in a transaction.

CC: @alexanderbez (#3091)


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #3328 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #3328      +/-   ##
==========================================
- Coverage    55.63%   55.6%   -0.03%     
==========================================
  Files          132     132              
  Lines         9559    9556       -3     
==========================================
- Hits          5318    5314       -4     
- Misses        3905    3906       +1     
  Partials       336     336

@hendrikhofstadt hendrikhofstadt changed the title Remove redundant action tag in x/gov R4R: Remove redundant action tag in x/gov Jan 21, 2019
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SLAMPER -- this indeed makes sense to me.

@jackzampolin
Copy link
Member

Thank you for the PR @SLAMPER! This is a good catch.

@jackzampolin jackzampolin merged commit d72e52b into cosmos:develop Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants