-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: LCD proof verification #3449
Merged
cwgoes
merged 16 commits into
develop
from
cwgoes/HaoyangLiu-irisnet/proof-verification
Jan 30, 2019
Merged
R4R: LCD proof verification #3449
cwgoes
merged 16 commits into
develop
from
cwgoes/HaoyangLiu-irisnet/proof-verification
Jan 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…risnet/proof-verification
…risnet/proof-verification
Fix LCD tests dependency
…er-fix Revert "Fix LCD tests dependency"
…ngLiu/cosmos-sdk into HaoyangLiu-irisnet/proof-verification
Turns out LCD tests were not in fact using isolated directories, as they pass individually. |
The problem is the singleton verifier, I think. |
Codecov Report
@@ Coverage Diff @@
## develop #3449 +/- ##
===========================================
- Coverage 59.49% 59.45% -0.05%
===========================================
Files 135 135
Lines 9981 9981
===========================================
- Hits 5938 5934 -4
- Misses 3671 3675 +4
Partials 372 372 |
alexanderbez
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3191
Closes: #2432
Recreate the singleton verifier if the home directory has changed.
This means that LCD proofs now test lite client verification.
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: