-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DecCoin bugs #4050
Comments
Oh I understand - various dec operations returning 0 due to rounding is expected behaviour, but the presence of 0 denoms within DecCoins is a bug, thus we need to check for introduction of 0 coins after dec operations on deccoins... correct? |
The rest, I'll address: |
parsedeccoins, i dunno about parsecoins, maybe, but parsedeccoins should remove zero any deccoins before returning. a zero deccoin is valid but not in a deccoins. |
Ref: #4095 |
MulDec can cause a product to be zero due to rounding. MulDecTruncate, QuoDec, and QuoDecTruncated as well. ParseDecCoin can return a zero coin but ParseDecCoins should not, so ParseDecCoins also has a bug
The text was updated successfully, but these errors were encountered: