remove duplicated account check and test #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
changed the title
|
Apologies @fedekunze, but I think #3960 addressed this. Can you verify? |
fedekunze
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4068 +/- ##
===========================================
- Coverage 60.01% 59.83% -0.18%
===========================================
Files 212 212
Lines 15107 15158 +51
===========================================
+ Hits 9066 9070 +4
- Misses 5420 5444 +24
- Partials 621 644 +23 |
fedekunze
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alessio
approved these changes
Apr 8, 2019
alexanderbez
approved these changes
Apr 9, 2019
alessio
reviewed
Apr 9, 2019
.pending/improvements/gaiacli/3426-remove-redundant-account-check
Outdated
Show resolved
Hide resolved
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: