Unregistered interface types.Evidence

[whunmr]

Summary of Bug

Got Unregistered interface types.Evidence in response of rest-api blocks/latest
when latest block contains DuplicateVoteEvidence in our chain.

Version

v0.36.0-rc1

Steps to Reproduce

• prepare chain state and let latest block contains DuplicateVoteEvidence
• curl http://localhost:27000/blocks/latest
• will got

{
    "error": "Unregistered interface types.Evidence"
}

tests

Maybe we should add RegisterEvidences(cdc) in codec/codec.go:54

func init() {
	cdc := New()
	RegisterCrypto(cdc)
	Cdc = cdc.Seal()
}

Got same error in following tests, and the test can pass if we add RegisterEvidences(cdc) in init()

type Codec = amino.Codec
var My *Codec
func New() *Codec {
	return amino.NewCodec()
}

func RegisterCrypto(cdc *Codec) {
	cryptoAmino.RegisterAmino(cdc)
}
var Cdc *Codec
func init() {
	cdc := New()
	RegisterCrypto(cdc)
	//RegisterEvidences(cdc)
	Cdc = cdc.Seal()
}

func TestEvidenceList(t *testing.T) {
	ev := randomDuplicatedVoteEvidence()
	evl := EvidenceList([]Evidence{ev})

	assert.NotNil(t, evl.Hash())
	assert.True(t, evl.Has(ev))
	assert.False(t, evl.Has(&DuplicateVoteEvidence{}))

	x := Cdc.MustMarshalJSON(evl)
	fmt.Println(string(x))
}

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Yes, good catch @whunmr. We should add a proxy call in codec.go which calls Tendermint's evidence.RegisterEvidences.