Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulation config #4906

Merged
merged 8 commits into from
Aug 15, 2019
Merged

simulation config #4906

merged 8 commits into from
Aug 15, 2019

Conversation

fedekunze
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #4906 into master will increase coverage by 0.07%.
The diff coverage is 54.28%.

@@            Coverage Diff             @@
##           master    #4906      +/-   ##
==========================================
+ Coverage   53.63%   53.71%   +0.07%     
==========================================
  Files         270      270              
  Lines       16982    16997      +15     
==========================================
+ Hits         9109     9130      +21     
+ Misses       7184     7178       -6     
  Partials      689      689

@fedekunze fedekunze added the R4R label Aug 14, 2019
@fedekunze fedekunze marked this pull request as ready for review August 14, 2019 16:52
@fedekunze fedekunze added WIP and removed R4R labels Aug 14, 2019
@fedekunze fedekunze added R4R and removed WIP labels Aug 15, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Look's cleaner already. I just have a single bit of feedback 👍

x/simulation/config.go Outdated Show resolved Hide resolved
x/simulation/config.go Show resolved Hide resolved
simapp/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ⚡️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a few of the sims locally; non-determinism seems weird.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK 👍

@alexanderbez alexanderbez merged commit 57cc5ae into master Aug 15, 2019
@alexanderbez alexanderbez deleted the fedekunze/simulation-config branch August 15, 2019 15:35
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants