Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readability in handleQueryP2P #4965

Closed
fedekunze opened this issue Aug 28, 2019 · 1 comment
Closed

improve readability in handleQueryP2P #4965

fedekunze opened this issue Aug 28, 2019 · 1 comment

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Aug 28, 2019

handleQueryP2P this should use the inverse conditional for improved readability:

if len(path) < 4 {
        msg := "path should be p2p filter <addr|id> <parameter>"
	return sdk.ErrUnknownRequest(msg).QueryResult()
}

...

Originally posted by @fedekunze in #4748

@alexanderbez alexanderbez changed the title improve readability in baseapp/abci.go improve readability in handleQueryP2P Dec 24, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants