Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS02 keeper tests #5311

Closed
4 tasks
fedekunze opened this issue Nov 13, 2019 · 2 comments
Closed
4 tasks

ICS02 keeper tests #5311

fedekunze opened this issue Nov 13, 2019 · 2 comments
Assignees
Labels

Comments

@fedekunze
Copy link
Collaborator

Keeper and Querier tests are missing on ICS02. I'd leave out the tests of VerifyMembership and VerifyNonMembership as we need to update those functions in following PR to the latest IBC-RC (see cosmos/ibc#293 for reference).

cc: @AdityaSripal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@AdityaSripal
Copy link
Member

AdityaSripal commented Nov 18, 2019

The keeper doesn't seem to do anything non-trivial apart from VerifyMembership, VerifyNonMembership, and CheckMisbehavior all of which is still a work in progress from my understanding.

I think the Keeper tests are blocked on getting the above done, but definitely point out anything else that should be tested in keeper

Can still test Get/Set methods

@AdityaSripal AdityaSripal mentioned this issue Nov 19, 2019
5 tasks
@AdityaSripal
Copy link
Member

Closed via #5329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants