Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Events Emitted from the AnteHandler #6186

Closed
4 tasks
alexanderbez opened this issue May 11, 2020 · 0 comments · Fixed by #6187
Closed
4 tasks

Track Events Emitted from the AnteHandler #6186

alexanderbez opened this issue May 11, 2020 · 0 comments · Fixed by #6187
Assignees

Comments

@alexanderbez
Copy link
Contributor

Summary of Bug

Events were initially designed and intended to be emitted during message handlers and ABCI begin/end block executors. However, due to the design and various use cases IBC introduces, it is desirable to also emit events during the AnteHandler.

Any events currently emitted during the AnteHandler will not be captured and returned to Tendermint. I think we can easily support and fix this by updating BaseApp#runTx to grab the events from ctx and add/merge them into the result's events before returning.

Version

138e0b0

/cc @zmanian @fedekunze


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants