Cleanup IBC types tests

[colin-axner]

Summary

Some of the types tests in IBC submodules could use spring cleaning.

Problem/Propsal

Redundant/unnecessary variable definitions. Strings should use a defined const not for example in connection/msgs_test.go "ibconntest". make a var connID = "ibconntest"

In msgs_test reduce code lines by combining message definitions with test case definition. It is extra technical debt to maintain correct test number ordering (for example: msg[3]).

Use test case struct for with the format:

type MsgTestCase struct {
    name string
    msg *sdk.Msg // or specific message type
    expPass bool
}

Use MsgTestSuite instead of just *testing.T.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.