Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ADR 25: IBC Passive Channels #53

Closed
4 tasks
fedekunze opened this issue Jul 9, 2020 · 6 comments
Closed
4 tasks

Implement ADR 25: IBC Passive Channels #53

fedekunze opened this issue Jul 9, 2020 · 6 comments

Comments

@fedekunze
Copy link
Contributor

Implement ADR 025 - IBC passive Channels


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cwgoes
Copy link
Contributor

cwgoes commented Aug 12, 2020

@michaelfig Do you want to implement this, or should someone else take it on?

@michaelfig
Copy link

I'd love to see this implemented, and would be even happier if someone else did it! Would be willing to review PRs.

@cwgoes
Copy link
Contributor

cwgoes commented Aug 20, 2020

I'd love to see this implemented, and would be even happier if someone else did it! Would be willing to review PRs.

Do you still need it on Agoric's end? I think Agoric is probably best able to implement this since you have the clearest idea of the requirements for contract interactions (though it might be good to consult with CosmWASM as well).

@michaelfig
Copy link

Do you still need it on Agoric's end? I think Agoric is probably best able to implement this since you have the clearest idea of the requirements for contract interactions (though it might be good to consult with CosmWASM as well).

That's fine with me, I'm just not sure when we'll get the cycles to do this. It is not strictly necessary for us until we start having contracts that dynamically establish new IBC channels across existing IBC connections.

@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 5, 2021
@ethanfrey
Copy link
Contributor

ethanfrey commented Mar 5, 2021

This may be obsolete now. I managed to get all this functionality (passively watching all channels on a given connection) simply by adding a packetConnection attribute to sendpackets and acknowledgement events: cosmos/cosmos-sdk#8458

This is enough for our ts-relayer to auto-detect two channels (that's as far as we've gone in the CI tests)

@colin-axner
Copy link
Contributor

Closing since I believe the desired features are already supported. Please let me know if I am incorrect in this assumption

faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
Prevent storing wasm code in simulation mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants